speclint police

ksh/ksh.spec

@@ -23,6 +23,7 @@
 ##  SUCH DAMAGE.
 ##
 
+#   package versions
 %define       V_pkg   20030422
 %define       V_ksh   2003-04-22
 %define       V_init  2003-04-22
@@ -37,7 +38,7 @@ Distribution: OpenPKG [BASE]
 Group:        Shell
 License:      AT&T
 Version:      %{V_pkg}
-Release:      20030424
+Release:      20030428
 
 #   list of sources
 Source0:      http://www.research.att.com/~gsf/download/tgz/ast-ksh.%{V_ksh}.tgz
@@ -67,8 +68,8 @@ Conflicts:    pdksh
     %setup1 -q -T -D -a 1
 
 %build
-    ./bin/package read || true
+    ./bin/package "read" || true
-    ./bin/package make CC="%{l_cc}"
+    ./bin/package "make" CC="%{l_cc}"
 
 %install
     rm -rf $RPM_BUILD_ROOT

ncurses/ncurses.spec

@@ -55,7 +55,7 @@ Distribution: OpenPKG [BASE]
 Group:        Terminal
 License:      GPL
 Version:      %{V_base}.%{V_patchL}
-Release:      20030420
+Release:      20030428
 
 #   list of sources
 Source0:      ftp://invisible-island.net/ncurses/ncurses-%{V_base}.tar.gz
@@ -97,10 +97,10 @@ AutoReqProv:  no
           -e 's;patch -p1;%{l_patch} -p1;' \
           patchbase.sh
       sh patchbase.sh )
-    for patch in \
+    for patchfile in \
         %{expand:%(i=1; while [ $i -le %{V_patches} ]; do %{l_shtool} echo -n " %%{PATCH$i}"; i=`expr $i + 1`; done)}
     do
-        %{l_gzip} -d -c $patch | %{l_patch} -p1 || true
+        %{l_gzip} -d -c $patchfile | %{l_patch} -p1 || true
     done
 
 %build

pax/pax.spec

@@ -23,6 +23,7 @@
 ##  SUCH DAMAGE.
 ##
 
+#   package versions
 %define       V_here  20030422
 %define       V_init  2003-04-22
 %define       V_base  2003-04-22
@@ -37,7 +38,7 @@ Distribution: OpenPKG [EVAL]
 Group:        Filesystem
 License:      AT&T
 Version:      %{V_here}
-Release:      20030424
+Release:      20030428
 
 #   list of sources
 Source0:      http://www.research.att.com/~gsf/download/tgz/ast-base.%{V_base}.tgz
@@ -63,8 +64,8 @@ AutoReqProv:  no
     %setup1 -q -T -D -a 1
 
 %build
-    ./bin/package read || true
+    ./bin/package "read" || true
-    ./bin/package make CC="%{l_cc}" LDFLAGS="-static"
+    ./bin/package "make" CC="%{l_cc}" LDFLAGS="-static"
 
 %install
     rm -rf $RPM_BUILD_ROOT

spamassassin/spamassassin.spec

@@ -23,7 +23,7 @@
 ##  SUCH DAMAGE.
 ##
 
-#   FIXME: rse: build step is to be moved to the %build section when
+#   FIXME: rse: build step is to be moved to the build section when
 #   FIXME: rse: perl-openpkg offers adequate support for this
 #   FIXME: cs:  provide better default configuration
 #   FIXME: cs:  spamc/spamd configuration not tested
@@ -39,7 +39,7 @@ Distribution: OpenPKG [EVAL]
 Group:        Mail
 License:      GPL/Artistic
 Version:      2.53
-Release:      20030330
+Release:      20030428
 
 #   list of sources
 Source0:      http://www.spamassassin.org/released/Mail-SpamAssassin-%{version}.tar.gz

tiff/tiff.spec

@@ -33,7 +33,7 @@ Distribution: OpenPKG [BASE]
 Group:        Graphics
 License:      GPL
 Version:      3.5.7
-Release:      20020416
+Release:      20030428
 
 #   list of sources
 Source0:      ftp://ftp.remotesensing.org/pub/libtiff/tiff-v%{version}.tar.gz
@@ -68,28 +68,28 @@ AutoReqProv:  no
         $RPM_BUILD_ROOT%{l_prefix}/include/tiff \
         $RPM_BUILD_ROOT%{l_prefix}/man/man1 \
         $RPM_BUILD_ROOT%{l_prefix}/man/man3
-    (cd libtiff && tar cf - libtiff.*) |\
+    (cd libtiff && %{l_tar} cf - libtiff.*) |\
-    (cd $RPM_BUILD_ROOT%{l_prefix}/lib && tar xf -)
+    (cd $RPM_BUILD_ROOT%{l_prefix}/lib && %{l_tar} xf -)
-    (cd libtiff && tar cf - *.h) |\
+    (cd libtiff && %{l_tar} cf - *.h) |\
-    (cd $RPM_BUILD_ROOT%{l_prefix}/include/tiff && tar xf -)
+    (cd $RPM_BUILD_ROOT%{l_prefix}/include/tiff && %{l_tar} xf -)
     (cd tools
      for tool in *; do
          if [ -x $tool ]; then
              echo $tool
          fi
      done
-    ) | (cd tools && xargs tar cf -) |\
+    ) | (cd tools && xargs %{l_tar} cf -) |\
-    (cd $RPM_BUILD_ROOT%{l_prefix}/bin && tar xf -)
+    (cd $RPM_BUILD_ROOT%{l_prefix}/bin && %{l_tar} xf -)
-    (cd man/apps && tar cf - *.1) |\
+    (cd man/apps && %{l_tar} cf - *.1) |\
-    (cd $RPM_BUILD_ROOT%{l_prefix}/man/man1 && tar xf -)
+    (cd $RPM_BUILD_ROOT%{l_prefix}/man/man1 && %{l_tar} xf -)
     (cd man/lib
      for manpage in *.3t; do
          base=`echo $manpage | sed -e 's;\.3t$;;'`
          mv $base.3t $base.3
          echo $base.3
      done
-    ) | (cd man/lib && xargs tar cf -) |\
+    ) | (cd man/lib && xargs %{l_tar} cf -) |\
-    (cd $RPM_BUILD_ROOT%{l_prefix}/man/man3 && tar xf -)
+    (cd $RPM_BUILD_ROOT%{l_prefix}/man/man3 && %{l_tar} xf -)
     (cd $RPM_BUILD_ROOT%{l_prefix}/lib
         rm -f libtiff.so* libtiff.def 2>&1 || true
     )